Demongrrl: 1 revision imported

2026-04-23T22:21:43Z

1 revision imported

← Older revision	Revision as of 08:21, 24 April 2026
(No difference)

wikipedia>Yodin: /* Dark mode: title always blue */ more ce

2026-04-23T17:24:52Z

Dark mode: title always blue: more ce

New page

{{ user:MiszaBot/config
| maxarchivesize = 31K
| minthreadsleft = 4
| minthreadstoarchive = 1
| counter = 7
| algo = old(90d)
| archive = Module talk:Sidebar/Archive %(counter)d
}}
{{copied|from=Module:Sidebar|from_oldid=816157517|to=:incubator:Module:Wp/nod/Sidebar|to_diff=4304026}}
{{to do |inner=
* [[/Archive 5#Nomobile use]]
* [[/Archive 5#Make tables into divs instead|#Make tables into divs instead]]
* [[/Archive 5#Width auto and similar sidebars]]
}}
{{archives|search=yes|bot=MiszaBot II|age=90}}
{{Lua sidebar}}

== ARIA ==

{{edit template-protected|answered=yes}}
Hi, per WIA-ARIA, can the parent {{tag|table|o}} HTML element with classes <code>sidebar sidebar-collapse nomobile nowraplinks</code> please get an ARIA role. Like the Mbox templates (see [[Module:Message box]], I was thinking <code>role="none"</code> is most appropriate. Although, in this case since most sidebars are navigation boxes it may be helpful to able to pass a boolean parameter to change the ARIA role given to <code>role="navigation"</code>.

@[[User:Izno|Izno]] What do you think? Sorry, I'm browsing around with my screenreader and noticed the sidebar also uses HTML tables still... Are you also on-board with <code>role="none"</code> and a boolean argument to switch this to <code>role="navigation"</code>?

(P.S. future me or someone else kind enough I can proof it—will have to also explain clearly and succinctly in sidebar and sidebar with collapsible lists template docs how to use lists (that expose {{tag|ul|o}}, {{tag|li|o}}, etc.) and be ARIA-friendly i.e. grouping them so they're read out usefully, labelling (!!) so important as otherwise a long babelling electronic voice of hyperlinks is all the visually impaired has for reference etc. if this is even possible to achieve on WP...) [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 02:47, 1 September 2025 (UTC)

:Sidebars are either nav or aside, if we were to use HTML elements that I don't current have access to. I'll mark it up as nav for now in the sandbox. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 16:57, 1 September 2025 (UTC)
::Thanks. I'm pretty confident that this particular WIA-ARIA work such as assigning roles to HTML elements whose semantics are incongruent to their use-case is an uncontroversial edit despite it being such a high-use page. Placing edit request.
::Kindly at the HTML attribute <code>role="navigation"</code> to the parent {{tag|table|o}} element please. This will replace the implicit semantics of a data table with the explicit semantics of a navigation group/group of links (the identical semantics as {{tag|nav|o}}) to accessibility technology.
::I guessed this, so please don't slate me:
{{textdiff|<nowiki>:css('width', args.width or nil)
:cssText(args.bodystyle or args.style)</nowiki>
|<nowiki>:css('width', args.width or nil)
:cssText(args.bodystyle or args.style)
:attr("role", "navigation")</nowiki>}}
::or is it <code>setAttribute("role", "navigation")</code>? I feel like the former.[[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 17:39, 1 September 2025 (UTC)
:::Or you can just say sync to the sandbox. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 19:13, 1 September 2025 (UTC)
:{{not done for now}}''':''' Going to wait until RedBurn finishes their work. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 15:56, 2 September 2025 (UTC)
::Good day @[[User:Izno|Izno]]. Please can you just insert the code I posted below for now. There's no timeline how long it may take the sandbox editing/testing to finish, and this edit won't need much testing beyond me checking ten or so use-cases that it actually shows up... At line 156, insert the highlighted code: <syntaxhighlight lang=lua line start="144" highlight="13" style="width:100%;font-size:small;">
root = root:tag('table')
if not child then
root
:addClass(cfg.i18n.class.sidebar)
-- force collapsibleclass to be sidebar-collapse otherwise output nothing
:addClass(collapsibleClass == cfg.i18n.class.collapse and cfg.i18n.class.collapse or nil)
:addClass('nomobile')
:addClass(args.float == cfg.i18n.float_none and cfg.i18n.class.float_none or nil)
:addClass(args.float == cfg.i18n.float_left and cfg.i18n.class.float_left or nil)
:addClass(args.wraplinks ~= cfg.i18n.wrap_true and cfg.i18n.class.wraplinks or nil)
:addClass(args.bodyclass or args.class)
:css('width', args.width or nil)
:attr('role', 'presentation')
:cssText(args.bodystyle or args.style)
</syntaxhighlight> Thank you [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 16:19, 7 September 2025 (UTC)
:::The reason I have not done so is because we expect to have two changes and I'm preventing the [[WP:Job queue]] from having to swallow two in some relatively quick procession (editing highly used modules has been observed by the WMF before). Users have lived with the change for many many years and is relatively minor at the end of the day. There is also 0 reason to test it any further. You should move on to more productive activities. And lastly, setting role to presentation is already what we're not doing. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 16:29, 7 September 2025 (UTC)
::::Ah ok got you. Thanks for the education 😄. Observed meaning it was able to cause enough performance issues that WMF was able to track the cause all the way down to a module? Insane.
::::{{tq| You should move on to more productive activities.}} Please watch your tone though. [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 20:19, 7 September 2025 (UTC)
::::If it’s in retaliation because I came across with tone I do apologise, the web doesn’t come with emotion semantics unless you use an emoticon 😅 [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 20:21, 7 September 2025 (UTC)
:::::@[[User:Waddie96|Waddie96]] I went ahead and implemented <source lang=lua inline>:attr("role", "navigation")</source> along with some other changes I was making, since The RedBurn's changes above appear to be stalled. --[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|TALK PAGE]]) 18:12, 29 December 2025 (UTC)

{{edit request|ans=yes}}

Please adjust line-height to be in keeping with the increase at {{tl|infobox}}.
<syntaxhighlight lang=css>
.sidebar {
line-height: 1.5em;
}
</syntaxhighlight> [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 04:49, 14 September 2025 (UTC)

:Reason being: Currently, links etc. will be too bunched together, and it actually makes it 'harder' to read from an usability perspective since it appears busy/cluttered and 'a lot'. [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 04:49, 14 September 2025 (UTC)
::As always with this editor: Where are the links to test cases? This module is used in 400K+ pages. Also, please link to the relevant "increase at {{tl|infobox}}". – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 14:57, 18 September 2025 (UTC)
==How come this thing still uses tables?==
[https://en.wikipedia.org/w/index.php?title=Module%3ASidebar%2Fsandbox&diff=1326372818&oldid=1309357365 I just replaced all table elements with <code><nowiki><div></nowiki></code> in the sandbox] and it has exactly the same appearance in all [[Template:Sidebar/testcases|testcases]] except one (Politics of Panama). So how come this thing still uses tables? [[user:sapphaline|sapphaline]] ([[user talk:sapphaline|talk]]) 16:55, 8 December 2025 (UTC)
:Your edits created a bunch of Linter errors at [[:Template:Sidebar/testcases]]. I've already cleaned up after you at [[:Template:Infobox rugby biography/sandbox]] today. Please clean up after yourself when you are done. Thanks. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 20:30, 8 December 2025 (UTC)

== Images on mobile ==

I was recently reviewing @[[User:Noleander|Noleander]]'s FAC nomination of [[Bridge]], which uses the {{t|Bridge sidebar}} sidebar in the lead section. That sidebar (like many others) includes an image, which is effectively the lead section's visual. I noticed that, because the sidebar is configured not to display on mobile, it results in there being no lead image on mobile.

Would it be possible for this module to detect when there is an image in a sidebar and display that on mobile, even when the sidebar as a whole is not? (Perhaps we'd want to limit it to lead sections.) Or would that be too technically complicated/introduce other complexities, in which case it might be better to implement on a per-article basis using {{t|If mobile}}? [[User:Sdkb|Sdkb]] [[User talk:Sdkb|'''talk''']] 21:02, 13 December 2025 (UTC)

== Alternative text for image ==

I added a brief instruction on how to provide alternative text for the sidebar image, as is required for [[WP:ALT]]. This is not an obscure detail: I had no idea how to do it 10 months ago, and I posted a query here in this Talk page, and got an answer. Then the same question came up yesterday in an FAC review. There may be lots of editors that have tried to help blind users by adding alt text to sidebar images, and gave up. The mechanism is not at all obvious, even to experienced editors, because many expect the "alt" attribute to be a sibling of the "image" attribute So, I added instructions. I inserted the instructions within the "image" attribute explanation. [[User:Noleander|Noleander]] ([[User talk:Noleander|talk]]) 15:17, 10 March 2026 (UTC)

== Dark mode: title always blue ==

In dark mode, the title is always blue, as if it was an unvisited wikilink (regardless of if the reader has visited the page or not), even when on the title's subject page (e.g. [[Rhetoric]]). Light mode is completely unaffected by this, with the title appearing as expected. I noticed that [[Module talk:Sidebar/Archive 7#Title always link-blue?|this had been raised before]], and the relevant CSS rule identified, but it wasn't fixed at the time as it wasn't clear why the rule existed. As this discussion points out, the CSS change [[Special:Diff/1234103998|was made in 2024]] by @[[User:Jdlrobson|Jdlrobson]] (@[[User:Jon (WMF)|Jon (WMF)]]), with an edit summary saying it was in response to [[mw:Reading/Web/Accessibility_for_reading/Reporting/en.wikipedia.org/Archive_1#%E2%9C%85Fall_of_Constantinople_dark_mode_error|this dark mode error report]]. I've checked [[Template:History of the Byzantine Empire sidebar|the template mentioned in the report]], which now seems to be working fine in dark mode even when you disable the CSS rule. @[[User:Jdlrobson|Jdlrobson]]: would you object to this CSS rule being removed, to allow the title to appear as expected? --[[User:Yodin|Yodin]][[User talk:Yodin|T]] 15:30, 23 April 2026 (UTC)

Module talk:Sidebar - Revision history

Demongrrl: 1 revision imported

wikipedia>Yodin: /* Dark mode: title always blue */ more ce